Skip to content

feat: add showLbaStatus to support LBA Status Log #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangru-stx wants to merge 1 commit into
base: develop
Choose a base branch
from
+80 −1
Open

feat: add showLbaStatus to support LBA Status Log #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions include/openseachest_util_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2352,6 +2352,14 @@ extern "C"
DEPOP_MAX_LBA_LONG_OPT_STRING, required_argument, M_NULLPTR, 0 \
}

#define SHOW_LBA_STATUS_FLAG showLbaStatus
#define SHOW_LBA_STATUS_VAR getOptBool SHOW_LBA_STATUS_FLAG = goFalse;
#define SHOW_LBA_STATUS_LONG_OPT_STRING "showLbaStatus"
#define SHOW_LBA_STATUS_LONG_OPT \
{ \
SHOW_LBA_STATUS_LONG_OPT_STRING, no_argument, &SHOW_LBA_STATUS_FLAG, goTrue \
}

// TCG Band/Range info
#define SHOW_LOCKED_REGIONS showLockedRegions
#define SHOW_LOCKED_REGIONS_VAR getOptBool SHOW_LOCKED_REGIONS = goFalse;
Expand Down Expand Up @@ -4832,6 +4840,8 @@ extern "C"

void print_Repopulate_Elements_Help(bool shortHelp);

void print_Show_Lba_Status_Help(bool shortHelp);

void print_Show_Locked_Regions_Help(bool shortHelp);

void print_SCT_Error_Recovery_Read_Help(bool shortHelp);
Expand Down
11 changes: 11 additions & 0 deletions src/openseachest_util_options.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3705,6 +3705,17 @@ void print_Repopulate_Elements_Help(bool shortHelp)
}
}

void print_Show_Lba_Status_Help(bool shortHelp)
{
printf("\t--%s\n", SHOW_LBA_STATUS_LONG_OPT_STRING);
if (!shortHelp)
{
print_str("\t\tUse this option to see range & status of\n");
print_str("\t\tLBAs inside a drive.\n");
print_str("\n");
}
}

void print_Show_Locked_Regions_Help(bool shortHelp)
{
printf("\t--%s\n", SHOW_LOCKED_REGIONS_LONG_OPT_STRING);
Expand Down
60 changes: 59 additions & 1 deletion utils/C/openSeaChest/openSeaChest_Format.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ int main(int argc, char* argv[])
REMOVE_PHYSICAL_ELEMENT_MOD_ZONES_VAR
REPOPULATE_ELEMENTS_VAR
DEPOP_MAX_LBA_VAR
SHOW_LBA_STATUS_VAR
NVM_FORMAT_VARS
NVM_FORMAT_OPTION_VARS
#if defined(ENABLE_CSMI)
Expand Down Expand Up @@ -167,6 +168,7 @@ int main(int argc, char* argv[])
REMOVE_PHYSICAL_ELEMENT_LONG_OPT,
REMOVE_PHYSICAL_ELEMENT_MOD_ZONES_LONG_OPT,
REPOPULATE_ELEMENTS_LONG_OPT,
SHOW_LBA_STATUS_LONG_OPT,
DEPOP_MAX_LBA_LONG_OPT,
NVM_FORMAT_LONG_OPT,
NVM_FORMAT_OPTIONS_LONG_OPTS,
Expand Down Expand Up @@ -897,7 +899,7 @@ int main(int argc, char* argv[])
// check for other tool specific options here
|| FORMAT_UNIT_FLAG || DISPLAY_LBA_FLAG || (PROGRESS_CHAR != M_NULLPTR) || SHOW_FORMAT_STATUS_LOG_FLAG ||
SET_SECTOR_SIZE_FLAG || SHOW_SUPPORTED_FORMATS_FLAG || SHOW_PHYSICAL_ELEMENT_STATUS_FLAG ||
REMOVE_PHYSICAL_ELEMENT_FLAG > 0 || REPOPULATE_ELEMENTS_FLAG || NVM_FORMAT_FLAG ||
REMOVE_PHYSICAL_ELEMENT_FLAG > 0 || REPOPULATE_ELEMENTS_FLAG || NVM_FORMAT_FLAG || SHOW_LBA_STATUS_FLAG ||
REMOVE_PHYSICAL_ELEMENT_MOD_ZONES_FLAG > 0
))
{
Expand Down Expand Up @@ -2073,6 +2075,60 @@ int main(int argc, char* argv[])
}
}

if (SHOW_LBA_STATUS_FLAG)
{
uint64_t numberOfDescriptors = UINT64_C(0);
eReturnValues getLbaStatusRet = get_Number_Of_LBA_Status_Descriptors(&deviceList[deviceIter], &numberOfDescriptors);
if (getLbaStatusRet == SUCCESS && numberOfDescriptors > 0)
{
ptrLbaStatusDescriptor descriptorList = M_REINTERPRET_CAST(
ptrLbaStatusDescriptor, safe_malloc(numberOfDescriptors * sizeof(lbaStatusDescriptor)));
if (descriptorList != M_NULLPTR)
{
safe_memset(descriptorList, numberOfDescriptors * sizeof(lbaStatusDescriptor), 0,
numberOfDescriptors * sizeof(lbaStatusDescriptor));
if (SUCCESS == get_LBA_Status_Descriptors(&deviceList[deviceIter], numberOfDescriptors,
descriptorList))
{
show_LBA_Status_Descriptors(numberOfDescriptors, descriptorList);
}
else
{
if (VERBOSITY_QUIET < toolVerbosity)
{
print_str("Failed to get physical element status.\n");
}
exitCode = UTIL_EXIT_OPERATION_FAILURE;
}
safe_free_lba_status(&descriptorList);
}
else
{
if (VERBOSITY_QUIET < toolVerbosity)
{
print_str("Unable to allocate memory for LBA Status descriptors\n");
}
exitCode = UTIL_EXIT_OPERATION_FAILURE;
}
}
else if (getLbaStatusRet == SUCCESS)
{
if (VERBOSITY_QUIET < toolVerbosity)
{
print_str("No LBA Status descriptor present on this device.\n");
}
exitCode = UTIL_EXIT_OPERATION_NOT_SUPPORTED;
}
else
{
if (VERBOSITY_QUIET < toolVerbosity)
{
print_str("The LBA Status feature is not supported on this device.\n");
}
exitCode = UTIL_EXIT_OPERATION_NOT_SUPPORTED;
}
}

if (PROGRESS_CHAR != M_NULLPTR)
{
eReturnValues result = UNKNOWN;
Expand Down Expand Up @@ -2188,6 +2244,7 @@ void utility_Usage(bool shortUsage)
printf("\t%s -d %s --%s 2\n", util_name, deviceHandleExample, REMOVE_PHYSICAL_ELEMENT_LONG_OPT_STRING);
printf("\t%s -d %s --%s 2\n", util_name, deviceHandleExample, REMOVE_PHYSICAL_ELEMENT_MOD_ZONES_LONG_OPT_STRING);
printf("\t%s -d %s --%s\n", util_name, deviceHandleExample, REPOPULATE_ELEMENTS_LONG_OPT_STRING);
printf("\t%s -d %s --%s\n", util_name, deviceHandleExample, SHOW_LBA_STATUS_LONG_OPT_STRING);
printf("\t%s -d %s --%s\n", util_name, deviceHandleExample, SHOW_SUPPORTED_FORMATS_LONG_OPT_STRING);
printf("\t%s -d %s --%s\n", util_name, deviceHandleExample, SHOW_FORMAT_STATUS_LOG_LONG_OPT_STRING);
printf("\t%s -d %s --%s current --%s\n", util_name, deviceHandleExample, FORMAT_UNIT_LONG_OPT_STRING,
Expand Down Expand Up @@ -2261,6 +2318,7 @@ void utility_Usage(bool shortUsage)
// multiple interfaces
print_Depop_MaxLBA_Help(shortUsage);
print_Show_Physical_Element_Status_Help(shortUsage);
print_Show_Lba_Status_Help(shortUsage);
print_Show_Supported_Formats_Help(shortUsage);
// SATA Only Options
// print_str("\n\tSATA Only:\n\n");
Expand Down
Loading