Skip to content

Conversation

@pascalaubry
Copy link
Collaborator

@pascalaubry pascalaubry commented Jan 6, 2026

Done:

  • pass the client to the print views to set the correct writer
  • add warnings for undeclared values
  • add FFE/Sharly Chess logo
  • Form T1 to T7
  • Form Fiche d’indemnités

Missing (moved to #1652):

  • add contact information and FFE licence (plugin data) for accounts, used to generate FFE reports (@Molrn ?)
  • replace multi-lines inputs by textareas (@timothyarmes ?)
  • pass the writer as a new account option (@pascalaubry)
  • form plainte/suspicion de tricherie (@pascalaubry)
  • form Attestation de stage AFC (@pascalaubry)
  • form Attestation de stage AFO (@pascalaubry)
  • mark accounts with RoleType ORGANISER

@pascalaubry pascalaubry added this to the 3.5 milestone Jan 6, 2026
@pascalaubry pascalaubry marked this pull request as ready for review January 6, 2026 02:42
@pascalaubry pascalaubry requested a review from Amaras as a code owner January 6, 2026 02:42
Copy link
Collaborator

@Molrn Molrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of comments, most important one is merging all the documents into one. Very nice PR otherwise :)

@pascalaubry pascalaubry marked this pull request as draft January 10, 2026 23:53
@pascalaubry pascalaubry marked this pull request as draft January 10, 2026 23:53
Molrn
Molrn previously requested changes Jan 11, 2026
Copy link
Collaborator

@Molrn Molrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Feels weird to have "Documents" this many times, I suggest "Formulaires FFE"

add contact information and FFE licence (plugin data) for accounts, used to generate FFE reports (@Molrn ?)

Let's keep the PRs small, this is adding too much to this one. Same for all the new docs, they can be done in a later one.

@pascalaubry
Copy link
Collaborator Author

Feels weird to have "Documents" this many times, I suggest "Formulaires FFE"

add contact information and FFE licence (plugin data) for accounts, used to generate FFE reports (@Molrn ?)

Let's keep the PRs small, this is adding too much to this one. Same for all the new docs, they can be done in a later one.

Done for "Formulaires FFE".
OK to stop now on this one, I start a new branch feature/ffe-technical-report-2 based on feature/ffe-technical-report.

@pascalaubry pascalaubry dismissed Molrn’s stale review January 11, 2026 09:19

All remarks taken into account.

@pascalaubry pascalaubry marked this pull request as ready for review January 11, 2026 09:19
@pascalaubry pascalaubry requested a review from Molrn January 11, 2026 09:19
@pascalaubry pascalaubry changed the title Add print views for FFE forms T1-T7 FFE forms step 1 - Add print views for forms T1-T7 Jan 12, 2026
@pascalaubry pascalaubry changed the title FFE forms step 1 - Add print views for forms T1-T7 FFE forms step 1 - Add forms T1-T7 Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants