Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start the dev session if there are build errors #5230

Merged

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 17, 2025

WHY are these changes introduced?

We don't want to even start the dev-session if any of the extensions failed to build.

WHAT is this pull request doing?

  • If there are build errors, don't start the session and finish the process
  • Add a new method to display errors in multiple extensions with a better UI

How to test your changes?

  1. Create 2 extensions with build error (for example, change import to importa)
  2. Run shopify app dev
  3. Verify that:
    • Build errors are displayed with proper formatting
    • The extension handle is shown as a prefix
    • The dev session is aborted with an appropriate error message

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@isaacroldan isaacroldan marked this pull request as ready for review January 17, 2025 16:30
@isaacroldan isaacroldan requested a review from a team as a code owner January 17, 2025 16:30
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.19% (-0.07% 🔻)
8891/11825
🟡 Branches
70.42% (-0.01% 🔻)
4333/6153
🟡 Functions
75.01% (-0.1% 🔻)
2335/3113
🟡 Lines
75.75% (-0.06% 🔻)
8402/11092
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / dev-session.ts
79.31% (-6.3% 🔻)
66.67% (-0.52% 🔻)
79.49% (-9.08% 🔻)
84.8% (-6.43% 🔻)

Test suite run success

2004 tests passing in 905 suites.

Report generated by 🧪jest coverage report action from fe089c6

Base automatically changed from 01-17-improve_dev-session_retry_and_error_report to main January 21, 2025 12:14
@isaacroldan isaacroldan added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 28cfaea Jan 21, 2025
1 check passed
@isaacroldan isaacroldan deleted the 01-17-don_t_start_the_dev_session_if_there_are_build_errors branch January 21, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants