Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start the dev session if there are build errors #5230

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Don't start the dev session if there are build errors #5230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f7760
Don't start the dev session if there are build errors
isaacroldan Jan 17, 2025
fe089c6
Remove test
isaacroldan Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/app/src/cli/services/dev/processes/dev-session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,15 @@ export const pushUpdatesForDevSession: DevProcessFunction<DevSessionOptions> = a
)
})
.onStart(async (event) => {
const buildErrors = event.extensionEvents.filter((eve) => eve.buildResult?.status === 'error')
if (buildErrors.length) {
const errors = buildErrors.map((error) => ({
error: 'Build error. Please review your code and try again.',
prefix: error.extension.handle,
}))
await printMultipleErrors(errors, processOptions.stdout)
throw new AbortError('Dev session aborted, build errors detected in extensions.')
}
const result = await bundleExtensionsAndUpload({...processOptions, app: event.app})
await handleDevSessionResult(result, {...processOptions, app: event.app})
})
Expand Down Expand Up @@ -335,6 +344,16 @@ async function printError(message: string, stdout: Writable, prefix?: string) {
await printLogMessage(outputContent`${content}`.value, stdout, prefix)
}

async function printMultipleErrors(errors: {error: string; prefix: string}[], stdout: Writable) {
const header = outputToken.errorText(`❌ Error`)
await printLogMessage(outputContent`${header}`.value, stdout, 'dev-session')
const messages = errors.map((error) => {
const content = outputToken.errorText(`└ ${error.error}`)
return printLogMessage(outputContent`${content}`.value, stdout, error.prefix)
})
await Promise.all(messages)
}

async function printSuccess(message: string, stdout: Writable) {
await printLogMessage(outputContent`${outputToken.green(message)}`.value, stdout)
}
Expand Down