Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gotcha for streaming responses #358

Merged
merged 3 commits into from
May 1, 2024
Merged

Add a gotcha for streaming responses #358

merged 3 commits into from
May 1, 2024

Conversation

byrichardpowell
Copy link
Contributor

WHY are these changes introduced?

By default streaming responses won't work. We should make that, and the workaround clear.

WHAT is this pull request doing?

Adds a section to the README

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

@byrichardpowell byrichardpowell requested a review from a team as a code owner September 22, 2023 18:07
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it'd be perfect if there are docs on defer / await for Remix that we could link to from here. But then again, if you're looking at this you're probably already aware of it 😄

@byrichardpowell byrichardpowell merged commit 9c4978b into main May 1, 2024
5 checks passed
paulomarg pushed a commit that referenced this pull request May 1, 2024
Add a gotcha for streaming responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants