Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Scrip tags manager #1948

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[minor] Scrip tags manager #1948

wants to merge 6 commits into from

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Mar 10, 2025 •
edited
Loading

What this PR does

  • This PR adds the a script tag manager to the shopify_app gem.

  • This functionality was removed in version 22 of this package.

  • Script tags are still a valid way for modify the content of vintage themes.

  • This PR has several differences between the previous script tag manager

    • Not the manager adds script tags with GraphQL instead of REST
    • This adds the ability to specify whether or not the script tags should be cached
    • You can now specify a template to check for before adding the script tag
      • Script tags should not be used if the theme has a valid template
    • Change the name from scripttag_manager to script_tag_manager
script_tag-720.mov

Reviewer's guide to testing

Things to focus on

  1. Is the documentation clear?
  2. Has functionality been restored?

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@lizkenyon lizkenyon requested a review from a team as a code owner March 10, 2025 22:24
@lizkenyon lizkenyon force-pushed the liz/add-scriptags-manager branch 2 times, most recently from a9aefb3 to f09e915 Compare March 11, 2025 15:09
@lizkenyon lizkenyon changed the title [WIP] scriptags manager [minor] Scrip tags manager Mar 11, 2025
@lizkenyon
Initial scripttag manager
c22647b 
Add check for app blocks

Add docs

Update naming

rubo cop

rubo cop
@lizkenyon
changelog
7aafea2
@lizkenyon lizkenyon force-pushed the liz/add-scriptags-manager branch from 7ef47f6 to 7aafea2 Compare March 11, 2025 16:56
@lizkenyon lizkenyon mentioned this pull request Mar 11, 2025
Open
5 tasks
sle-c
sle-c reviewed Mar 11, 2025
View reviewed changes
@lizkenyon lizkenyon force-pushed the liz/add-scriptags-manager branch 2 times, most recently from 24c114b to 75cde50 Compare March 12, 2025 18:59
@lizkenyon lizkenyon force-pushed the liz/add-scriptags-manager branch from 75cde50 to 385d1e6 Compare March 12, 2025 19:27
sle-c
sle-c approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sle-c sle-c sle-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizkenyon @sle-c