Allow Names on Preset Blocks #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miazbikowski
commented
Feb 18, 2025
| "name": "Nested Text Block", | ||
| "settings": {} | ||
| } | ||
| ] |
There was a problem hiding this comment.
Added a nested block since there wasn't one.
veken1199
reviewed
Feb 19, 2025
| @@ -24,9 +24,17 @@ | |||
| "blocks": [ | |||
| { | |||
| "type": "thing", | |||
| "name": "The Thing", | |||
There was a problem hiding this comment.
changing these fixtures did not require updating any tests?
There was a problem hiding this comment.
The tests that run on these fixtures test that they are valid, so by adding this and having the existing tests be green, I prove that names are now valid.
If you wanna tophat, you can also clone this repo, and if you tweak these json fixtures, it'll actually run the json schema on the fixtures in real time (you'll see any of your errors in your IDE), which is super helpful when you're updating the json schema!
veken1199
approved these changes
Feb 20, 2025
veken1199
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Theme Blocks "Preset Name Passing" subproject, we can now put
nameon any section or block preset nested block and set it a string value.Some examples
The feature tech doc
Slack channel