Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing + prettier support for param name and description in doc tags #665

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add parsing + prettier support for param name and description in doc tags #665

merged 1 commit into from
Dec 19, 2024

Conversation

jamesmengo
Copy link
Contributor

What are you adding in this PR?

What's next? Any followup issues?

What did you learn?

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@jamesmengo jamesmengo mentioned this pull request Dec 11, 2024
Merged
2 tasks
@jamesmengo Graphite App
Copy link
Contributor Author

jamesmengo commented Dec 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 11, 2024
Closed
Merged
Merged
@jamesmengo jamesmengo force-pushed the jm/basic_prettier_support branch from d4803fa to 0f17fef Compare December 11, 2024 00:29
@jamesmengo jamesmengo force-pushed the jm/liquid_doc_param_description branch from de13e20 to 7df1d2d Compare December 11, 2024 00:29
@jamesmengo
Add Parsing + Prettier support for LiquidDoc paramName and paramDescr…
dd1f0a1 
…iption

Stage 1 -  capture `paramName` and `paramDescription` from the input string.

Stage 2 - Extend LiquidDocParamNode to include paramName and paramDescription

Add prettier support for paramNode and paramDescription

Stage 1: Introduce parsing for concrete paramName and paramDescription types

Stage 2: Translate paramDescription and paramName into TextNode

Prettier supoprt for paramDescription and paramName
@jamesmengo jamesmengo force-pushed the jm/liquid_doc_param_description branch from 7df1d2d to dd1f0a1 Compare December 11, 2024 00:42
@jamesmengo jamesmengo changed the base branch from jm/basic_prettier_support to jm/implement_fallbackNode December 11, 2024 00:42
@jamesmengo jamesmengo changed the title Update grammar to support liquidDocParamName and liquidDocParamDescription Add support for @param name and description in doc tags Dec 11, 2024
@jamesmengo jamesmengo changed the title Add support for @param name and description in doc tags Add parsing + prettier support for @param name and description in doc tags Dec 11, 2024
@jamesmengo jamesmengo changed the title Add parsing + prettier support for @param name and description in doc tags Add parsing + prettier support for param name and description in doc tags Dec 11, 2024
@jamesmengo jamesmengo mentioned this pull request Dec 11, 2024
Merged
8 tasks
@jamesmengo jamesmengo marked this pull request as ready for review December 19, 2024 23:07
@jamesmengo jamesmengo merged commit 4bf7625 into jm/implement_fallbackNode Dec 19, 2024
6 checks passed
@jamesmengo jamesmengo deleted the jm/liquid_doc_param_description branch December 19, 2024 23:07
This was referenced Jan 7, 2025
Merged
Merged
This was referenced Jan 20, 2025
Merged
Closed
Merged
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamesmengo