Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing + prettier support for param type in {% doc %} tags #666

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jamesmengo
Copy link
Contributor

What are you adding in this PR?

What's next? Any followup issues?

What did you learn?

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@jamesmengo jamesmengo force-pushed the jm/liquid_doc_param_description branch from 7df1d2d to dd1f0a1 Compare December 11, 2024 00:42
@jamesmengo jamesmengo changed the title Support paramType in LiquidDoc Parser + Prettier Add type support for param type in {% doc %} tags Dec 11, 2024
@jamesmengo jamesmengo changed the title Add type support for param type in {% doc %} tags Add parsing + prettier support for param type in {% doc %} tags Dec 11, 2024
Base automatically changed from jm/liquid_doc_param_description to jm/implement_fallbackNode December 19, 2024 23:07
@jamesmengo jamesmengo marked this pull request as ready for review December 19, 2024 23:07
@jamesmengo jamesmengo merged commit 169d143 into jm/implement_fallbackNode Dec 19, 2024
6 checks passed
@jamesmengo jamesmengo deleted the jm/liquid_doc_type branch December 19, 2024 23:08
@jamesmengo jamesmengo added the #gsd:44310 LiquidDoc label Feb 3, 2025 — with Graphite App
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:44310 LiquidDoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant