Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grammar to allow variables to be detected inside style tags #683

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update grammar to allow variables to be detected inside style tags #683

wants to merge 1 commit into from

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Jan 3, 2025

NOTE: DO NOT MERGE YET

  • After some testing, I found out that removing it from the raw tag section will format inside the style tag (changing a lot of files)

What are you adding in this PR?

Fixes #465

  • Style tag was being treated as a "raw" tag where liquid code isn't parsed inside it
    • Removed style tag from this list

Tophat

Before After
image image

Before you deploy

  • I included a patch bump changeset

@aswamy aswamy force-pushed the bugfix/variable-not-used-false-positive branch from 5b01888 to 3363584 Compare January 6, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False Positive "Variable Assigned but Not Used" in Style Tags
1 participant
@aswamy