Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammar to allow variables to be detected inside style tags #683

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update grammar to allow variables to be detected inside style tags #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-moose-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/liquid-html-parser': patch
---

[Bug Fix] Update grammar to allow liquid variables to be detected inside style tags
2 changes: 1 addition & 1 deletion packages/liquid-html-parser/grammar/liquid-html.ohm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ Liquid <: Helpers {
| liquidRawTagImpl<"javascript">
| liquidRawTagImpl<"schema">
| liquidRawTagImpl<"stylesheet">
| liquidRawTagImpl<"style">
liquidRawTagImpl<name> =
"{%" "-"? space* (name endOfIdentifier) space* tagMarkup "-"? "%}"
anyExceptStar<liquidRawTagClose<name>>
Expand Down Expand Up @@ -297,6 +296,7 @@ Liquid <: Helpers {
blockName =
// Shopify blocks
( "form"
| "style"
| "paginate"
// Base blocks
| "capture"
Expand Down
Loading