Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recommendations in blocks #857

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Conversation

JoviDeCroock
Copy link
Contributor

What are you adding in this PR?

This adds support for leveraging the recommendations global in blocks/, currently we allow it in sections but not in blocks. We've been using this in a block and it's been great so thought I'd add support into the theme check.

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
    • I've made a PR to update the shopify.dev theme check docs if applicable (link PR here).

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner March 17, 2025 13:15
Copy link
Contributor

@charlespwd charlespwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To TypeSystem too for completion/hover support?

Copy link

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this exists; if so, making theme check aware of that 👍

@graygilmore graygilmore merged commit 846b966 into main Mar 21, 2025
7 checks passed
@graygilmore graygilmore deleted the allow-recommendations-in-blocks branch March 21, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants