-
Notifications
You must be signed in to change notification settings - Fork 53
Fix event types #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix event types #2770
Conversation
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250415150153" |
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250415163640" |
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250415175606" |
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250415203727" |
b984abe to
bd3dbdb
Compare
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250421181747" |
bd3dbdb to
8e31d13
Compare
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250421182514" |
8be9cf6 to
3441ec5
Compare
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250422211948" |
3441ec5 to
286514c
Compare
|
/snapit |
|
🫰✨ Thanks @vividviolet! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250422220349" |
henrytao-me
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩-ed. LGTM
Background
Fix https://github.com/Shopify/app-ui/issues/2211
🎩
0.0.0-snapshot-20250421182514snapshot with the fixed types. Note that the types for the snapshot was generated with this PR for building individual d.ts files for each component.pnpm installto install the snapshotEventfor the Button onClick handlerChecklist