Make linting its own workflow#317
Merged
Merged
Conversation
sfc-gh-npuka
force-pushed
the
naisila/ci-tests
branch
from
d9f5d01 to
e1c1924
Compare
Signed-off-by: sfc-gh-npuka <naisila.puka@snowflake.com>
sfc-gh-npuka
force-pushed
the
naisila/ci-tests
branch
from
e1c1924 to
2af7297
Compare
sfc-gh-dachristensen
approved these changes
Apr 16, 2026
| # style/indent-related changes | ||
|
|
||
| # This target ensures that we download the PG_INDENT_VERSION's typedefs.list | ||
| # This target ensures that we download the latest major version's typedefs.list |
Collaborator
There was a problem hiding this comment.
This is technically the target major version, not latest, since it'll depend on what is getting built.
|
|
||
| $(TYPEDEFS): | ||
| curl -o $(TYPEDEFS) https://buildfarm.postgresql.org/cgi-bin/typedefs.pl?branch=REL_$(PG_INDENT_VERSION)_STABLE | ||
| curl -o $(TYPEDEFS) https://buildfarm.postgresql.org/cgi-bin/typedefs.pl?branch=REL_$(PG_MAJOR_VERSION)_STABLE |
Collaborator
There was a problem hiding this comment.
We don't have to do this in this PR, but I'd definitely love to get our custom types registered in the typedefs list, so some sort of script/way to maintain these and combine with the Postgres typedefs would be awesome. (More just a TODO that has been rattling in my head for a while...)
Collaborator
Author
There was a problem hiding this comment.
taking a note of that
Collaborator
Author
There was a problem hiding this comment.
wow, seems like we have a lot of formatting issues to fix #319
Signed-off-by: sfc-gh-npuka <naisila.puka@snowflake.com>
3 tasks
sfc-gh-mslot
pushed a commit
that referenced
this pull request
May 1, 2026
lint-check-18 will error so we cannot merge a PR, but will allow the rest of the tests to run without needing to immediately fix a simple formatting bug. --- Signed-off-by: Naisila Puka <naisila.puka@snowflake.com>
sfc-gh-mslot
pushed a commit
that referenced
this pull request
May 1, 2026
lint-check-18 will error so we cannot merge a PR, but will allow the rest of the tests to run without needing to immediately fix a simple formatting bug. --- Signed-off-by: Naisila Puka <naisila.puka@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
lint-check-18will error so we cannot merge a PR, but will allow the rest of the tests to run without needing to immediately fix a simple formatting bug.Idea from @sfc-gh-dachristensen
Checklist