Get pg_lake's custom types in the typedefs list for pgindent#319
Open
sfc-gh-npuka wants to merge 3 commits into
Open
Get pg_lake's custom types in the typedefs list for pgindent#319sfc-gh-npuka wants to merge 3 commits into
sfc-gh-npuka wants to merge 3 commits into
Conversation
sfc-gh-npuka
force-pushed
the
naisila/type_formatting
branch
from
efd8fda to
f74f392
Compare
3 tasks
sfc-gh-npuka
force-pushed
the
naisila/type_formatting
branch
from
f74f392 to
51a25f3
Compare
Signed-off-by: sfc-gh-npuka <naisila.puka@snowflake.com>
Signed-off-by: sfc-gh-npuka <naisila.puka@snowflake.com>
sfc-gh-npuka
force-pushed
the
naisila/type_formatting
branch
from
51a25f3 to
1f695c3
Compare
…onIds The previous grep -v 'struct' filter discarded lines like "typedef struct CachedExtensionIdsData CachedExtensionIds;" before the alias pattern could extract CachedExtensionIds. Reformat affected files. Signed-off-by: sfc-gh-npuka <naisila.puka@snowflake.com>
sfc-gh-npuka
force-pushed
the
naisila/type_formatting
branch
from
1f695c3 to
8d12962
Compare
sfc-gh-npuka
changed the title
Collaborator
|
I recall some talk of moving to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Register pg_lake's custom types in the typedefs list, and combine with the Postgres typedefs for pg_indent. Idea from @sfc-gh-dachristensen #317 (comment)
This PR also fixes our current formatting issues.
Checklist