Skip to content

test(e2e): ensure valid config output format & commitlint success#931

Merged
kguzek merged 4 commits into
mainfrom
test/config-format
May 16, 2026
Merged

test(e2e): ensure valid config output format & commitlint success#931
kguzek merged 4 commits into
mainfrom
test/config-format

Conversation

@kguzek

@kguzek kguzek commented May 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@kguzek kguzek self-assigned this May 12, 2026
@kguzek
kguzek requested a review from a team as a code owner May 12, 2026 22:34
@kguzek kguzek added the javascript Pull requests that update Javascript code label May 12, 2026
@kguzek
kguzek requested a review from Copilot May 12, 2026 22:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the end-to-end/integration test suite by adding (a) an optional Prettier formatting check for generated config files and (b) a new integration test that exercises commitlint + husky’s commit-msg hook behavior.

Changes:

  • Added TestEnvironment.runPrettierCheckIfInstalled() to conditionally run prettier --check on specific paths.
  • Added a formatting assertion helper used across Next.js/NestJS/Vite integration tests to validate generated config output format.
  • Added a new “Commitlint Integration Tests” suite that performs a real git commit after installing commitlint/husky.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
tests/utils/test-environment.ts Adds conditional Prettier --check support and a helper to run git commit with a provided message.
tests/integration.test.ts Introduces formatting-check helper usage across integration tests and adds a new commitlint+husky integration test.

Comment thread tests/integration.test.ts
Comment thread tests/integration.test.ts
Comment thread tests/integration.test.ts
Comment thread tests/integration.test.ts
@kguzek
kguzek force-pushed the test/config-format branch from b2e5e80 to 245f921 Compare May 13, 2026 11:26
@pkg-pr-new

pkg-pr-new Bot commented May 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solvro/config@931

commit: 69307bc

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread tests/utils/test-environment.ts
Comment thread tests/utils/test-environment.ts Outdated
Comment thread tests/integration.test.ts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Comment thread src/cli/templates/node-setup-ci.ts
Comment thread tests/utils/test-environment.ts
@kguzek
kguzek added this pull request to the merge queue May 16, 2026
Merged via the queue into main with commit 6f269aa May 16, 2026
14 checks passed
@kguzek
kguzek deleted the test/config-format branch May 16, 2026 22:42
@solvro-ci

solvro-ci Bot commented May 24, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 2.4.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code released on @beta size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants