Skip to content

Remove deprecated config keys#347

Open
Nustat0 wants to merge 3 commits into
SpecialKO:mainfrom
Nustat0:remove-deprecated-config-keys
Open

Remove deprecated config keys#347
Nustat0 wants to merge 3 commits into
SpecialKO:mainfrom
Nustat0:remove-deprecated-config-keys

Conversation

@Nustat0

@Nustat0 Nustat0 commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Kaldaien

Copy link
Copy Markdown
Member

I really don't think that belongs inside the parameter class itself.

This class is used by not only Special K's DLL but also external plug-ins, they have their own INI files and applying behavior that's specific to Special K's core to them doesn't make much sense.

Really it would make more sense to write a loop in config.cpp to iterate over all parameters and remove the deprecated ones that way.

@Nustat0 Nustat0 force-pushed the remove-deprecated-config-keys branch from 71ed5dc to 08ec70e Compare March 21, 2026 21:17
@Nustat0

Nustat0 commented Mar 21, 2026

Copy link
Copy Markdown
Contributor Author

Really it would make more sense to write a loop in config.cpp to iterate over all parameters and remove the deprecated ones that way.

Could you take another look? Maybe it's better to use the newly created LegacyEntry macro?

If not, then I'll try to come up with something else that doesn't involve parameter class.

@Nustat0 Nustat0 force-pushed the remove-deprecated-config-keys branch from 55fcbad to 31cb70f Compare March 23, 2026 22:05
@Nustat0 Nustat0 force-pushed the remove-deprecated-config-keys branch from 31cb70f to d40e7c7 Compare April 4, 2026 21:59
@Nustat0 Nustat0 marked this pull request as draft April 4, 2026 23:00
@Nustat0 Nustat0 force-pushed the remove-deprecated-config-keys branch from 8604233 to 7b4e73f Compare April 5, 2026 10:52
@Nustat0 Nustat0 marked this pull request as ready for review April 5, 2026 11:14
@Nustat0 Nustat0 force-pushed the remove-deprecated-config-keys branch from c28deb6 to 4118ce6 Compare April 11, 2026 22:00
@Nustat0 Nustat0 force-pushed the remove-deprecated-config-keys branch from 4118ce6 to 640c88b Compare April 11, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants