feat: add Isaac Sim 4.5.0+ WebRTC streaming support#1947
Open
zhiyangc-ventures wants to merge 1 commit intoStanfordVL:mainfrom
Open
feat: add Isaac Sim 4.5.0+ WebRTC streaming support#1947zhiyangc-ventures wants to merge 1 commit intoStanfordVL:mainfrom
zhiyangc-ventures wants to merge 1 commit intoStanfordVL:mainfrom
Conversation
- Tries new extension name first (omni.kit.livestream.webrtc) for Isaac Sim 4.5.0+ - Falls back to old name (omni.services.streamclient.webrtc) for older versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds forward compatibility for Isaac Sim 4.5.0+ while maintaining backward compatibility with older versions.
Problem
Isaac Sim 4.5.0 renamed the WebRTC streaming extension:
omni.services.streamclient.webrtcomni.kit.livestream.webrtcThis causes OmniGibson to fail with "extension not found" when running with Isaac Sim 4.5.0+ and
OMNIGIBSON_REMOTE_STREAMING=webrtc.Solution
Try the new extension name first, fall back to the old name if it fails