[Enhancement] optimize variant seek path #67281
Merged
+71
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yan zhang <[email protected]>
Signed-off-by: yan zhang <[email protected]>
Signed-off-by: yan zhang <[email protected]>
dirtysalt
commented
Dec 28, 2025
| return Status::OK(); | ||
| }, | ||
| segment)); | ||
| if (current.is_null()) { |
Contributor
Author
There was a problem hiding this comment.
fast break if it's null value.
dirtysalt
commented
Dec 28, 2025
| } | ||
| } else { | ||
| // non-unique dictionary, find all matching indexes | ||
| } else if (hint == 0) { |
Contributor
Author
There was a problem hiding this comment.
hint = 0 means just return the first index
otherwise it means to search from this index.
dirtysalt
commented
Dec 28, 2025
| RETURN_IF_ERROR(search(0)); | ||
|
|
||
| // don't find key in the dict, then return null value. | ||
| if (dict_indexes.empty()) { |
Contributor
Author
There was a problem hiding this comment.
if there is no dict index found, we don't return error, but return null value.
remember this case is not a abnormal case.
dirtysalt
commented
Dec 28, 2025
| std::string_view raw() const { return _value; } | ||
| VariantType type() const; | ||
| VariantType type() const { | ||
| switch (basic_type()) { |
Contributor
Author
There was a problem hiding this comment.
inline this method.
dirtysalt
commented
Dec 28, 2025
| inline const char* assemble_state(TStatusCode::type code, std::string_view msg, std::string_view ctx) { | ||
| DCHECK(code != TStatusCode::OK); | ||
|
|
||
| if (msg.empty() && ctx.empty()) { |
Contributor
Author
There was a problem hiding this comment.
fast initialization
Signed-off-by: yan zhang <[email protected]>
dirtysalt
force-pushed
the
optimize-variant-path
branch
from
9ce2a4c to
f345716
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 3 / 3 (100.00%) file detail
|
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
alvin-celerdata
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
These optimizations reduce overhead by:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Improves Variant path/object/array navigation performance and semantics, plus a small Status optimization.
VariantMetadata::_get_indexto minimize scans for non-unique dicts; refactorget_object_by_keyto leverage hints and returnnullwhen key not found instead of errorsget_element_at_indexnow returnsnullfor out-of-bounds indices (was error);VariantPath::seekshort-circuits when current segment resolves tonullVariantValue::type()intovariant.hand addis_null()for fast checksStatusstate assembly for empty message/context pathNULL_TYPEinstead of errors for missing keys/OOB, and adjust SQL golden results to showNullwhere appropriateWritten by Cursor Bugbot for commit f345716. This will update automatically on new commits. Configure here.