Skip to content

Kf1.9 init common update #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 27, 2025

Conversation

mathis-marcotte
Copy link
Contributor

@mathis-marcotte mathis-marcotte marked this pull request as ready for review February 26, 2025 15:18
@mathis-marcotte
Copy link
Contributor Author

I am aware that the JWA Frontend Tests, as well as the publish workflows are failing. That is to be expected.
This PR only updates what is found under the ./frontend/common/kubeflow-common-lib folder.
The reason those workflows are failing, and the reason I can't fully run the app yet, is that code also needs to be updated under ./frontend/jupyter, to follow with the updates that were made to the common-lib.

But as we can see, the workflows for "Common Frontend Tests" still all successfully pass, those which actually touches the code I updated..

Copy link
Contributor

@wg102 wg102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathis-marcotte mathis-marcotte merged commit 6420f58 into KF1.9-jupyter-apis Feb 27, 2025
3 of 6 checks passed
@mathis-marcotte mathis-marcotte deleted the kf1.9-init-common-update branch February 27, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants