Add automatic retry on machine ID conflict#47
Merged
Conversation
f1cf3aa to
fed7b44
Compare
Signed-off-by: Lukas Kirylak <lukas@stellatarum.com>
fed7b44 to
7b16828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deploying a large count of machines at the same time (e.g. large cluster in Rancher), Proxmox can return the same "next ID" multiple times, and only one deployment will succeed. Rancher will retry deployment, but it takes a long time (there is no ID set in that case so Rancher tries to remove non-existing VM multiple times first).
How Has This Been Tested?
You can force specific ID to be set for the new machine like so:
I created a machine with
108first, then started creation of a second one, waited for retires to start and removed the initial machine - the driver created the new machine correctly.Checklist