Skip to content

Add automatic retry on machine ID conflict #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keyaray merged 1 commit into from
Jul 24, 2025
Merged

Add automatic retry on machine ID conflict #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions cmd/docker-machine-driver-pve/driver/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ import (
"context"
"errors"
"fmt"
"math/rand"
"net"
"slices"
"strings"
"time"

"github.com/luthermonson/go-proxmox"
"github.com/rancher/machine/libmachine/drivers"
Expand Down Expand Up @@ -103,16 +105,34 @@ func (d *Driver) Create() error {

log.Info("Creating the machine...")

vmid, err := d.createPVEVirtualMachine(context.TODO())
if err != nil {
if vmid > 0 {
log.Warn("Machine might have been created with ID='%d'", vmid)
retryBackoff := 1 // seconds

for {
vmid, err := d.createPVEVirtualMachine(context.TODO())
if err != nil {
if strings.Contains(err.Error(), "config file already exists") {
log.Warn("Hit ID conflict when cloning the machine, will retry...")

//nolint:gosec // Weak number generator is good enough for this case
<-time.After(time.Duration(retryBackoff+rand.Intn(retryBackoff)) * time.Second)

// Double the backoff for next iteration
retryBackoff *= 2

continue
}

if vmid > 0 {
log.Warnf("Machine might have been created with ID='%d'", vmid)
}

return fmt.Errorf("failed to create machine: %w", err)
}

return fmt.Errorf("failed to create machine: %w", err)
}
d.PVEMachineID = &vmid

d.PVEMachineID = &vmid
break
}

if err := d.initialize(); err != nil {
if removeErr := d.Remove(); removeErr != nil {
Expand Down