fix: Hyperlinks do not work#6288
Open
John-pillo1124 wants to merge 2 commits intoStirling-Tools:mainfrom
Open
Conversation
John-pillo1124
requested review from
ConnorYoh,
EthanHealy01,
Frooodle,
jbrunton96 and
reecebrowne
as code owners
dosubot
Bot
added
size:L
stirlingbot
Bot
added
the
Front End
jbrunton96
reviewed
May 1, 2026
Contributor
jbrunton96
left a comment
jbrunton96
left a comment
There was a problem hiding this comment.
Thanks for doing this. There's a couple of important things that need to be changed before this can be merged, but if they get fixed then this will be a good change to make 🙂
Comment on lines
+12
to
+13
| import FavoriteStar from "@app/components/tools/toolPicker/FavoriteStar"; | ||
| import FavoriteStar from "@app/components/tools/toolpicker/FavoriteStar"; |
Contributor
There was a problem hiding this comment.
This shouldn't have been changed. It'll only work on case-insensitive OSs
| * Check if we're running in a Tauri desktop environment | ||
| * @returns True if running in Tauri | ||
| */ | ||
| export function isTauriEnvironment(): boolean { |
Contributor
There was a problem hiding this comment.
Please review frontend/DeveloperGuide.md to see how to design desktop fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
I've fixed hyperlink functionality issues in the Stirling PDF desktop application (Tauri/Windows version). The problems were:
Testing Considerations
window.openshould work as beforenoopener,noreferrersecurity attributes preservedImpact
The fix resolves the reported issues while maintaining backward compatibility and improving the codebase structure for handling external URLs in mixed web/desktop environments.