fix: Hyperlinks do not work #6288
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /** | ||
| * Utility functions for handling URLs in both web and Tauri environments | ||
| */ | ||
|
|
||
| /** | ||
| * Check if we're running in a Tauri desktop environment | ||
| * @returns True if running in Tauri | ||
| */ | ||
| export function isTauriEnvironment(): boolean { | ||
|
Contributor
There was a problem hiding this comment. Please review frontend/DeveloperGuide.md to see how to design desktop fixes |
||
| return typeof window !== 'undefined' && | ||
| (window as any).__TAURI__ !== undefined; | ||
| } | ||
|
|
||
| /** | ||
| * Open a URL in the appropriate way for the current environment | ||
| * @param url - The URL to open | ||
| * @param target - The target window (default: "_blank") | ||
| * @param features - Window features (default: "noopener,noreferrer") | ||
| */ | ||
| export function openUrl( | ||
| url: string, | ||
| target: string = "_blank", | ||
| features: string = "noopener,noreferrer" | ||
| ): void { | ||
| // Check if we're in Tauri environment | ||
| if (isTauriEnvironment()) { | ||
| // Use void to avoid returning Promise from this function | ||
| void (async () => { | ||
| try { | ||
| // Dynamically import Tauri shell plugin only in Tauri environment | ||
| const { open } = await import('@tauri-apps/plugin-shell'); | ||
| await open(url); | ||
| return; | ||
| } catch (error) { | ||
| console.warn('[urlUtils] Failed to open URL with Tauri shell, falling back to window.open:', error); | ||
| // Fall back to window.open if Tauri fails | ||
| window.open(url, target, features); | ||
| } | ||
| })(); | ||
| } else { | ||
| // Use standard window.open for web environment | ||
| window.open(url, target, features); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Check if a URL protocol is safe to open | ||
| * @param url - The URL to check | ||
| * @returns True if the URL protocol is safe (http, https, mailto) | ||
| */ | ||
| export function isSafeUrlProtocol(url: string): boolean { | ||
| try { | ||
| const urlObj = new URL(url, window.location.href); | ||
| return ['http:', 'https:', 'mailto:'].includes(urlObj.protocol); | ||
| } catch { | ||
| // If URL parsing fails, assume it's unsafe | ||
| return false; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't have been changed. It'll only work on case-insensitive OSs