Add support for multiple plurals to search results for Cyrillic languages#198
Merged
Conversation
OrsellGit
pushed a commit
that referenced
this pull request
May 30, 2026
Member
|
Just a reminder, please do not forget to run Prettier and check the results of the check test on GH before merging. While it's a fairly minor thing, a new PR / commit has to be made to account for this which isn't great for history. |
Member
|
Actually the warning on here seems to be from a past file from a change a while back. Even more reason to do it... Don't even let me get stuffed merged if it doesn't pass :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @Laveig.
This basically does what it says on the tin. Russian has two definitions of the word "plural", and the current version of search in P2:CE doesn't actually account for this:
This PR addresses that by adding a second loc string - one is for exactly two matches (
#Settings_General_Search_VeryFull_Plural), another is for more than two matches (#Settings_General_Search_VeryFull_Plural2) - the latter "duplicate" string exists and is used in place. This shouldn't be visible to the end-user on languages that don't have multiple plural terms.