CMRT 22: Feature: Nest Fingerprint Queue under Analyze + Status column - #29
Open
Swarnadip-Kar wants to merge 2 commits into
Open
CMRT 22: Feature: Nest Fingerprint Queue under Analyze + Status column#29Swarnadip-Kar wants to merge 2 commits into
Swarnadip-Kar wants to merge 2 commits into
Conversation
Coverage Report for CI Build 27523987007Coverage decreased (-0.006%) to 30.453%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Fingerprint Queue from a standalone top-level sidebar entry into
a child of the Analyze feature, and adds a single Status column to the
queue table model showing each track's AcoustID submission state.
Part A — Nest under Analyze
MusicBrainzQueueFeature is removed as a standalone feature. DlgMusicBrainzQueue
is now created by AnalysisFeature following the MixxxLibraryFeature +
DlgMissing / DlgHidden nesting pattern exactly:
MusicBrainzQueueFeature class files are deleted. DlgMusicBrainzQueue and
MusicBrainzQueueTableModel are unchanged structurally.
Part B — Status column
musicbrainz_queue_view gains a LEFT JOIN acoustid_queue to expose aq.status.
Tracks with fingerprint_valid=1 but never enqueued still appear; their
status is NULL, shown as "pending" by rawValue().
Notes for reviewers
but no queue row still appear; this makes the view a complete picture of
unmatched fingerprints, not just queued ones.
DlgMusicBrainzQueue::onShow() from CMRT 18 so no view state is lost.
except COL_STATUS, so standard library column behaviour is unchanged.
take effect without requiring a Mixxx restart.
Future work (not in this PR)
Depends on: cmrt-worker-mbid-fields (#27)