CMRT 24: DAO: Add getGroupsForMbid() and getAllGroupCandidates() - #33
Open
Swarnadip-Kar wants to merge 1 commit into
Open
CMRT 24: DAO: Add getGroupsForMbid() and getAllGroupCandidates()#33Swarnadip-Kar wants to merge 1 commit into
Swarnadip-Kar wants to merge 1 commit into
Conversation
Coverage Report for CI Build 27872292646Warning No base build found for commit Coverage: 30.437%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two read-only lookups the CMRT grouping pipeline needs as its
first step, before any fingerprint comparison happens. Pure plumbing —
no behavior changes for anything that already exists.
getGroupsForMbid(mbid)
Returns every cmrt_group whose canonical track's library row has the given
musicbrainz_recording_id. Joins through canonical_track_id rather than
adding an mbid column to cmrt_groups, since that FK already exists and
the canonical track's MBID is exactly what we want anyway.
getAllGroupCandidates()
Returns every cmrt_group, unfiltered. Only meant for the no-MBID fallback
path (AcoustID found no match for the new track, so there's nothing to
pre-filter the SimHash scan with). Documented as such in the header so it
doesn't get reached for in the normal case by mistake.
MbidGroupCandidate
New DTO carrying just group_id, fingerprint_hash, and canonical_track_id.
Deliberately smaller than CmrtGroup -- the SimHash pre-filter step (CMRT 26)
only needs these three fields, not the MusicBrainz-sync or local_preferred
columns CmrtGroup also carries.
Notes for reviewers
to call from the AcoustID worker thread.
same caveat as any full-table scan. Acceptable for now since it's a
fallback path, not the common case.
Depends on: CMRT Phase 1 (#32)