[ENH][packages/openigtlink] Add OpenIGTLink related packages #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelPalomar
force-pushed
the
feature/openigtl_packages
branch
from
9a7989c to
41df537
Compare
RafaelPalomar
force-pushed
the
feature/openigtl_packages
branch
from
41df537 to
f7ea486
Compare
oeramo
requested changes
May 27, 2025
Contributor
oeramo
left a comment
oeramo
left a comment
There was a problem hiding this comment.
Just a couple of minor changes, otherwise LGTM
|
|
||
| (define-public slicer-openigtlinkio | ||
| (package | ||
| (name "slicer-openigtlinkio") |
Contributor
There was a problem hiding this comment.
Should this be called "openigtlinkio"? The first package "slicer-openigtlink" is named so because it is a module for Slicer, using the same name convention here might confuse.
| qrestapi | ||
| openigtlink)) | ||
| (synopsis "synopsis") | ||
| (description "description") |
Contributor
There was a problem hiding this comment.
Proposed synopsis and description (from https://github.com/IGSIO/OpenIGTLinkIO):
(synopsis "Library for interfacing to openigtlink/OpenIGTLink, dependent on VTK and Qt. Based on openigtlink/OpenIGTLinkIF")
(description "OpenIGTLinkIO contains several wrapper layers on top of OpenIGTLink.
+The code originates from OpenIGTLink/OpenIGTLinkIF.
+The main intent of the library is to share igtl code between Slicer, CustusX, IBIS, MITK and other systems.")
f7ea486 to
0232dad
Compare
- This commit adds the `openigtlink`, `slicer-openigtlinkio` and `slicer-openigtlink` packages. Co-authored-by: Omar El Hajj <[email protected]>
RafaelPalomar
force-pushed
the
feature/openigtl_packages
branch
from
0232dad to
b20b50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openigtlink,slicer-openigtlinkioandslicer-openigtlinkpackages.