Favorite Lecture View #1498
Open
Favorite Lecture View #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feriel97
force-pushed
the
favorite_view_n
branch
from
b2d34e8 to
c02bfdf
Compare
SebiWrn
requested changes
Feb 26, 2025
| @@ -61,7 +61,7 @@ | |||
| {{if $stream.PlaylistUrl}} | |||
| <a class="text-left flex justify-start items-center w-full text-3 px-4 py-2 hover:cursor-pointer hover:bg-gray-200 dark:hover:bg-gray-600" | |||
| title="Combined view" | |||
| @click="watch.switchView('/w/{{$course.Slug}}/{{$stream.Model.ID}}')"> | |||
| @click="watch.switchView('/w/{{$course.Slug}}/{{$stream.Model.ID}}/COMB')"> | |||
There was a problem hiding this comment.
I think we don't need to add the '/COMB' at the end of the URL and thus shouldn't because the URL looks cleaner without.
| @@ -82,6 +82,21 @@ func (r mainRoutes) WatchPage(c *gin.Context) { | |||
| } | |||
| } | |||
|
|
|||
| if c.Param("version") == "" { | |||
There was a problem hiding this comment.
We're already checking for version != "" so maybe we should combine these with an if/else so code is more readable
karjo24
reviewed
Feb 26, 2025
Comment on lines
+88
to
+90
|
|
||
| c.Redirect(http.StatusFound, c.Request.RequestURI+"/PRES") | ||
|
|
There was a problem hiding this comment.
The unnecessary whitespace can be removed.
karjo24
reviewed
Feb 26, 2025
| case "Camera": | ||
| c.Redirect(http.StatusFound, c.Request.RequestURI+"/CAM") | ||
| case "Combined": | ||
| c.Redirect(http.StatusFound, c.Request.RequestURI+"/COMB") |
There was a problem hiding this comment.
If we choose to leave out /COMB at https://github.com/TUM-Dev/gocast/pull/1498/files#r1971590406, we can leave it out here as well afaik.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes issue #1426
Description
I have added a user setting "Preferred Lecture View" in the global user settings that allows the user to choose his preferred lecture mode : split, combined, presentation... I have then according to the preference updated the view shown ie the URL redirected to the preferred view of the student.
Steps for Testing
Prerequisites:
Screenshots