-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favorite Lecture View #1498
base: dev
Are you sure you want to change the base?
Favorite Lecture View #1498
Changes from all commits
4498821
47ec58c
7423cfa
c02bfdf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,21 @@ func (r mainRoutes) WatchPage(c *gin.Context) { | |
} | ||
} | ||
|
||
if c.Param("version") == "" { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're already checking for version != "" so maybe we should combine these with an if/else so code is more readable |
||
switch tumLiveContext.User.GetPreferredView() { | ||
case "Presentation": | ||
|
||
c.Redirect(http.StatusFound, c.Request.RequestURI+"/PRES") | ||
|
||
Comment on lines
+88
to
+90
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The unnecessary whitespace can be removed. |
||
case "Camera": | ||
c.Redirect(http.StatusFound, c.Request.RequestURI+"/CAM") | ||
case "Combined": | ||
c.Redirect(http.StatusFound, c.Request.RequestURI+"/COMB") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we choose to leave out |
||
case "Split": | ||
c.Redirect(http.StatusFound, c.Request.RequestURI+"/SPLIT") | ||
} | ||
} | ||
|
||
// Check for fetching progress | ||
if tumLiveContext.User != nil && tumLiveContext.Stream.Recording { | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to add the '/COMB' at the end of the URL and thus shouldn't because the URL looks cleaner without.