Integrate TDK (TYPO3 Development Kit) into contrib image#22
Open
dkd-dobberkau wants to merge 2 commits into
Open
Integrate TDK (TYPO3 Development Kit) into contrib image#22dkd-dobberkau wants to merge 2 commits into
dkd-dobberkau wants to merge 2 commits into
Conversation
- Add ochorocho/tdk as require-dev dependency with all TDK composer scripts (tdk:doctor, tdk:apply-patch, tdk:checkout, etc.) - Add GERRIT_USERNAME env var for automatic Gerrit push URL and Git user configuration - Auto-install commit-msg and pre-commit hooks from TYPO3 Core - Add .gitmessage.txt commit template for TYPO3 contributions - Auto-run TYPO3 setup on first start with default credentials - Run cache:flush, extension:setup, cache:warmup on every start - Fix TYPO3_CONTEXT from Production to Development - Accept both Gerrit and GitHub clone URLs in validation Closes #21 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The buildx docker-container driver needs GHCR credentials to pull the private base images during demo/contrib builds. Remove the pull_request condition from all login steps — push is already gated separately via the push parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
I'd prefer not to merge/proceed with this feature for now. I like the idea to have a container that can be used for We can't do everything all at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ochorocho/tdkasrequire-devdependency with all TDK composer scripts (tdk:doctor,tdk:apply-patch,tdk:checkout, etc.)GERRIT_USERNAMEenv var for automatic Gerrit push URL and Git user configuration.gitmessage.txtcommit template for TYPO3 contributionscontrib/Th4nx4H3lp1ng)cache:flush,extension:setup,cache:warmupon every container startTYPO3_CONTEXTfromProductiontoDevelopmentCloses #21
Test plan
GERRIT_USERNAMEsettypo3core/.git/configtypo3core/.git/hooks/git config commit.templatecomposer tdk:doctor,composer tdk:helpGERRIT_USERNAMEand verify graceful skip message🤖 Generated with Claude Code