Fix: prevent allow notifications prompt on rotation

[VougJo23]

What is it?

• [ x ] Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Add variable permissionStatus to check if the user has already granted or denied permission.

Before/After Screenshots/Screen Record

• Before:

notificationfix-before.mp4

• After:

notificationfix-after.mp4

Fixes the following issue(s)

• Fixes "allow NewPipe to send you notification" message appears again when changing from portait to landscape view #12194

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• [ x ] I read the contribution guidelines.

[Profpatsch]

I posted some notes on the original issue:

#12194 (comment)

[Profpatsch]

Okay here’s an answer by ChatGPT which I think corresponds exactly to what I figured out but in a pretty well-phrased manner:

Details

To check whether a user has explicitly denied a permission in an Android app (especially if they selected "Don't ask again"), you can use a combination of the ActivityCompat.shouldShowRequestPermissionRationale() method and ContextCompat.checkSelfPermission().

Key Concepts:

1. Permission denied temporarily: User just denied, but didn't select "Don't ask again".
2. Permission denied permanently: User denied and selected "Don't ask again", or the system is configured to no longer prompt.

Code Example (Kotlin):

val permission = Manifest.permission.CAMERA

when {
    ContextCompat.checkSelfPermission(context, permission) == PackageManager.PERMISSION_GRANTED -> {
        // Permission granted
    }

    ActivityCompat.shouldShowRequestPermissionRationale(activity, permission) -> {
        // Permission denied before, but "Don't ask again" NOT selected
        // Show rationale to user
    }

    else -> {
        // Permission denied before AND "Don't ask again" selected
        // Or first-time request on some devices
    }
}

Interpreting shouldShowRequestPermissionRationale():

• Returns true: User denied the permission before, but did not select "Don't ask again".

• Returns false:

  • The user denied and selected "Don't ask again", or
  • It's the first time asking (before any request was made).

To detect explicit denial with "Don't ask again":

You must track if the user was asked before, e.g., using SharedPreferences.

Combined Logic:

val sharedPref = context.getSharedPreferences("prefs", Context.MODE_PRIVATE)
val wasPermissionRequestedBefore = sharedPref.getBoolean("camera_permission_requested", false)

if (ContextCompat.checkSelfPermission(context, permission) != PackageManager.PERMISSION_GRANTED) {
    if (ActivityCompat.shouldShowRequestPermissionRationale(activity, permission)) {
        // Previously denied, but not "Don't ask again"
    } else if (wasPermissionRequestedBefore) {
        // Denied with "Don't ask again"
    } else {
        // First time request
        sharedPref.edit().putBoolean("camera_permission_requested", true).apply()
    }
}

So I think the solution here is to save a single boolean as you said @Stypox, and then never ask again when the system dialog is fulfilled once (by setting it in the callback handler)

[Profpatsch]

@Stypox I think I fixed it and implemented it correctly with the PermissionRequest callback thingy, PTAL

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Stypox]

Wait, this means that once it has been asked once, it will never ever be asked again. I just tested and if you dismiss the request by clicking outside of the permission dialog, NewPipe will never again ask. I think what we want is just to avoid asking twice in the same execution of the app. This can be achieved by setting wasAskedKey to false in App.onCreate(). Or probably directly using a boolean field in App is even better, without having to go through settings, since in theory the App instance is not recreated on orientation change.

[ShareASmile]

@Profpatsch I have re-added "waiting for review" by renaming it to "ready for review" as earlier name was creating confusion sometimes with "waiting for author" label (atleast for me) & I had deleted it last time after couple of messups. Due to time constraints I couldn't get to it earlier. As I looked at it coming back after a break, It looked rude in github events history, Sorry for that friends, it was unintentional & now I have made the amends for good.

[Stypox]

@VougJo23 hello, are you still interested in working on this? In particular implementing the solution suggested in: #12201 (comment) . Let me know, otherwise this PR can be closed, thanks in advance!

[Stypox]

Closing for now since @Isaac-75 now wants to work on it. Thanks for the solutions explored so far!