Skip to content

fix: prevent allow notifications prompt on rotation #12201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: prevent allow notifications prompt on rotation #12201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86e9d24
fix: prevent allow notifications prompt on rotation
VougJo23 Apr 23, 2025
b7e5637
fix: prevent allow notifications prompt on rotation
VougJo23 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions app/src/main/java/org/schabi/newpipe/util/PermissionHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,24 @@ public static boolean checkWriteStoragePermissions(final Activity activity,
return true;
}

public static boolean checkPostNotificationsPermission(final Activity activity,
public static boolean checkPostNotificationsPermission(final Activity activity,
final int requestCode) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU
&& ContextCompat.checkSelfPermission(activity,
Manifest.permission.POST_NOTIFICATIONS)
!= PackageManager.PERMISSION_GRANTED) {
final int permissionStatus = ContextCompat.checkSelfPermission(activity,
Manifest.permission.POST_NOTIFICATIONS);

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {

// If permission already granted, return true
if (permissionStatus == PackageManager.PERMISSION_GRANTED) {
return true;
}

// If user previously denied, don't ask again
if (ActivityCompat.shouldShowRequestPermissionRationale(activity,
Manifest.permission.POST_NOTIFICATIONS)) {
return false;
}

ActivityCompat.requestPermissions(activity,
new String[] {Manifest.permission.POST_NOTIFICATIONS}, requestCode);
return false;
Expand Down