Migrate settings appearance screen - #13684
Conversation
AudricV
added
rewrite
|
|
||
| @Singleton(binds = [AppearanceActions::class]) | ||
| class IOSAppearanceActions : AppearanceActions { | ||
| override fun openCaptionSettings() = Unit |
There was a problem hiding this comment.
It seems there is something like captions on iOS:
There was a problem hiding this comment.
based on my research looks like iOS has caption settings (Accessibility > Subtitles & Captioning / Live Captions), but no App-Store-safe way to deep-link in the app unless i have missed something. By default i have just set the new isCaptionSettingsAvailable method to false for the IOSAppearanceActions so the row will stay hidden
|
|
||
| @Singleton(binds = [AppearanceActions::class]) | ||
| class JVMAppearanceActions : AppearanceActions { | ||
| override fun openCaptionSettings() = Unit |
There was a problem hiding this comment.
Seems to be available on desktop:
- https://www.microsoft.com/en-gb/windows/tips/live-captions
- https://support.apple.com/en-me/guide/mac-help/mchldd11f4fd/mac
- For other platforms, the setting should be probably hidden?
There was a problem hiding this comment.
@theimpulson I have made some changes on this. Please take a look at my approach
| .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) | ||
| ) | ||
| } catch (exception: ActivityNotFoundException) { | ||
| Logger.e(messageString = "No activity found for captioning settings", throwable = exception) |
There was a problem hiding this comment.
If this isn't supported, we shouldn't be showing it
18cc747 to
3de4d35
Compare
3de4d35 to
3d04489
Compare
|
3 participants
What is it?
Description of the changes in your PR
ListPreferenceandSwitchPreferencereusable composablesAppearanceSettingsViewModelAppearancePreferencesso the screen, the view model, and theming all reference the same constantsAppearanceActionsplatform interface + per-platform implementations (AndroidAppearanceActions,JVMAppearanceActions,IOSAppearanceActions)Theme.ktto resolve colors from the sharedAppearancePreferencesconstants and observe changes viaObservableSettings, so theme edits made on the appearance screen apply liveAppearanceSettingsScreenTest,ListPreferenceTest,SwitchPreferenceTest.Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
Continuation of #13652
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence