ucentral-client: reject wildcard certs matching multi-level subdomains#10
Open
ArifAlam wants to merge 1 commit intoTelecominfraproject:mainfrom
Open
ucentral-client: reject wildcard certs matching multi-level subdomains#10ArifAlam wants to merge 1 commit intoTelecominfraproject:mainfrom
ArifAlam wants to merge 1 commit intoTelecominfraproject:mainfrom
Conversation
Per RFC 6125, a wildcard certificate like *.example.com should only match a single DNS label (e.g. foo.example.com), not multi-level subdomains (e.g. foo.bar.example.com). The existing validate_CN() only checked that the server name ended with the wildcard's domain suffix, allowing multi-level matches. Add a check that the prefix portion replacing the wildcard contains no dots. Fixes WIFI-15386 Signed-off-by: Arif Alam <arif.alam@netexperience.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 6125, a wildcard certificate like *.example.com should only match a single DNS label (e.g. foo.example.com), not multi-level subdomains (e.g. foo.bar.example.com). The existing validate_CN() only checked that the server name ended with the wildcard's domain suffix, allowing multi-level matches. Add a check that the prefix portion replacing the wildcard contains no dots.
Fixes WIFI-15386