Skip to content

ucentral-client: reject wildcard certs matching multi-level subdomains #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArifAlam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ucentral-client: reject wildcard certs matching multi-level subdomains #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ validate_CN(char *CN)
int CN_len;
int server_len;
int ret;
int prefix_len;

if (!strcmp(client.server, CN))
return 0;
Expand All @@ -103,10 +104,16 @@ validate_CN(char *CN)

ret = strcmp(&CN[1], &client.server[server_len - CN_len + 1]);

if (!ret)
ULOG_INFO("server is using a wildcard certificate\n");
if (ret)
return ret;

return ret;
prefix_len = server_len - CN_len + 1;
if (memchr(client.server, '.', prefix_len))
return -1;

ULOG_INFO("server is using a wildcard certificate\n");

return 0;
}

static void
Expand Down