Skip to content

Issue #1948: Multiple Tabs Using Crtl/Cmd - Click #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamu-sad-iii merged 2 commits into from
May 9, 2025
Merged

Issue #1948: Multiple Tabs Using Crtl/Cmd - Click #2042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32ac9c
adds events for windows and mac when using ctrl / cmd keys
qtamu Apr 9, 2025
a10f7b0
adds the event scope to the ng clicl
qtamu Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/main/webapp/app/controllers/submission/submissionListController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
vireo.controller("SubmissionListController", function (NgTableParams, $controller, $filter, $location, $q, $scope, ControlledVocabularyRepo, CustomActionDefinitionRepo, DepositLocationRepo, DocumentTypeRepo, EmailRecipient, EmailRecipientType, EmailTemplateRepo, EmbargoRepo, FieldPredicateRepo, FieldValueRepo, ManagerFilterColumnRepo, ManagerSubmissionListColumnRepo, NamedSearchFilterGroup, OrganizationRepo, OrganizationCategoryRepo, PackagerRepo, SavedFilter, SavedFilterRepo, SidebarService, SubmissionListColumnRepo, SubmissionRepo, SubmissionStatusRepo, UserRepo, UserSettings, WsApi) {
vireo.controller("SubmissionListController", function (NgTableParams, $controller, $filter, $location, $q, $scope, ControlledVocabularyRepo, CustomActionDefinitionRepo, DepositLocationRepo, DocumentTypeRepo, EmailRecipient, EmailRecipientType, EmailTemplateRepo, EmbargoRepo, FieldPredicateRepo, FieldValueRepo, ManagerFilterColumnRepo, ManagerSubmissionListColumnRepo, NamedSearchFilterGroup, OrganizationRepo, OrganizationCategoryRepo, PackagerRepo, SavedFilter, SavedFilterRepo, SidebarService, SubmissionListColumnRepo, SubmissionRepo, SubmissionStatusRepo, UserRepo, UserSettings, $window, WsApi) {

angular.extend(this, $controller('AbstractController', {
$scope: $scope
Expand Down Expand Up @@ -1002,8 +1002,14 @@ vireo.controller("SubmissionListController", function (NgTableParams, $controlle

var disabledFilterColumnOptions = createDisabledColumnOptions();

$scope.viewSubmission = function (submission) {
$location.path("/admin/view/" + submission.id);
$scope.viewSubmission = function (event, submission) {
const url = $location.absUrl();
if (event.ctrlKey || event.metaKey) {
$window.open(url.replace('/list', '/view/' + submission.id));
event.stopPropagation();
} else {
$location.path('/admin/view/' + submission.id);
};
};

SidebarService.addBoxes([{
Expand Down
2 changes: 1 addition & 1 deletion src/main/webapp/app/views/admin/list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ <h1>List ETDs</h1>
</tr>
</thead>
<tbody>
<tr ng-repeat="row in $data" ng-init="$last && finished()" ng-click="viewSubmission(row)" class="select-toggle submission-list-row">
<tr ng-repeat="row in $data" ng-init="$last && finished()" ng-click="viewSubmission($event, row)" class="select-toggle submission-list-row">
<td ng-repeat="col in $columns">
<span ng-class="{'glyphicon glyphicon-remove-circle' : $first}" ng-click="addRowFilter($parent.$index, row)"></span>
<span ng-if="col.title() !== 'Custom Actions'">{{displaySubmissionProperty(row, col)}}</span>
Expand Down
Loading