Skip to content

Conversation

@jeffng-or
Copy link
Contributor

Added description for inst name prefixes used when rsz & cts insert buffers.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@jeffng-or jeffng-or requested a review from maliberty April 23, 2025 21:41
@maliberty
Copy link
Member

@povik @precisionmoon please review for accuracy and completeness

Copy link
Contributor

@povik povik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks complete and accurate in so far as the rsz part except for comments

@precisionmoon
Copy link
Contributor

@jeffng-or , thanks much for documenting the name prefixes. This definitely improves tool usability.

Incorporated review feedback

Signed-off-by: Jeff Ng <[email protected]>
@jeffng-or jeffng-or force-pushed the inserted-inst-doc-addition branch from 02e495c to f6a20b4 Compare April 23, 2025 22:27
@jeffng-or
Copy link
Contributor Author

Thanks for the feedback. I've rev'd the rsz README

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

| load_slew | Fixing max transition violations |
| max_cap | Fixing max capacitance |
| max_length | Fixing max length |
| wire | Repairs load slew, length, and max capacitance violations in net wire segment |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have prefixes each of these separately above. How does wire differ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my read of RepairDesign.cc, wire is only used for the BufferedNetType::wire. The others are used for BufferedNetType::junction. wire is then used to address length, max_cap, or load_slew violations.

@jeffng-or
Copy link
Contributor Author

@maliberty, OK to merge?

@maliberty maliberty merged commit 8b7df0d into The-OpenROAD-Project:master May 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants