-
Notifications
You must be signed in to change notification settings - Fork 762
Added description of inserted inst name prefixes #7213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added description of inserted inst name prefixes #7213
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@povik @precisionmoon please review for accuracy and completeness |
povik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks complete and accurate in so far as the rsz part except for comments
|
@jeffng-or , thanks much for documenting the name prefixes. This definitely improves tool usability. |
Incorporated review feedback Signed-off-by: Jeff Ng <[email protected]>
02e495c to
f6a20b4
Compare
|
Thanks for the feedback. I've rev'd the rsz README |
|
clang-tidy review says "All clean, LGTM! 👍" |
| | load_slew | Fixing max transition violations | | ||
| | max_cap | Fixing max capacitance | | ||
| | max_length | Fixing max length | | ||
| | wire | Repairs load slew, length, and max capacitance violations in net wire segment | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have prefixes each of these separately above. How does wire differ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my read of RepairDesign.cc, wire is only used for the BufferedNetType::wire. The others are used for BufferedNetType::junction. wire is then used to address length, max_cap, or load_slew violations.
|
@maliberty, OK to merge? |
Added description for inst name prefixes used when rsz & cts insert buffers.