[pull] trunk from spiceai:trunk#691
Merged
Merged
Conversation
* Make S3 metadata column handling more robust # Conflicts: # Cargo.lock # Cargo.toml * Update location metadata column name (_location) * Update DF * Update DataFusion SHA --------- Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech> Co-authored-by: Evgenii Khramkov <evgenii@spice.ai>
The cloud API no longer returns api_key in the apps response. Update
spidapter and the Spice CLI to call GET /v1/apps/{appId}/api-keys to
retrieve API keys separately.
- Remove api_key field from App struct in spice-cloud-client types
- Change ensure_spice_cloud_app to return only the app ID
- Add cloud.get_api_keys(app_id) call in spidapter setup flow
- Update CLI create app command to fetch API key from dedicated endpoint
#9768) pull_request_target runs in the base branch context with full secrets access and is unnecessary for this workflow which only builds and runs tests. Using pull_request is the correct trigger and provides defense in depth alongside the org-level fork PR approval requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )