Add "-noborder" launch argument for borderless windowed mode #327

ShizCalev · 2025-03-03T16:29:40Z

WS_POPUP|WS_VISIBLE being the only flags = noborder.

Currently set to only trigger if both -win & -noborder are set as launch params, can simplify it down to just one of that's preferred.

GeneralsMD/Code/Main/WinMain.cpp

Co-authored-by: Cody Brittain <1779662+Generalcamo@users.noreply.github.com>

helmutbuhler · 2025-05-19T18:50:42Z

I don't quite understand what this new commandline option is for. In case you want the window to be completely visible, the recently merged PR #541 also addressed that. Would that be good enough?

ShizCalev · 2025-05-19T23:46:41Z

@helmutbuhler That PR has no connection to this one.

This PR removes the title bar / border that's around the game window. Hence, borderless windowed mode.

Without the PR:

With the PR:

(I also just noticed that the very corners of the client windows are rounded on windows 11 when borders are present, gross lol)

Generals/Code/Main/WinMain.cpp

GeneralsMD/Code/Main/WinMain.cpp

xezon · 2025-05-20T06:25:09Z

What is the benefit of no border?

ShizCalev · 2025-05-20T07:48:14Z

What is the benefit of no border?

....huh? Borderless windowed mode is a pretty standard feature in like 99% of modern games. It's entirely a personal preference/asthetic option, as a large number of folks hate seeing brightly colored title bars.

This does not change the default behavior, it just adds a command line option to enable the option.

Trax1990 · 2025-05-20T07:59:28Z

What is the benefit of no border?

I seriously hope you’re joking.

Mauller · 2025-05-20T08:10:12Z

This is not adding a true "Borderless window" mode as the game does not properly support that and it needs to be added internally. The game needs to support scaling the rendering output within the window based on the chosen resolution etc.

With the recent window centering fix, if you run the game in a window and with your resolution matching the desktop it will remove the window borders and fill the screen. This mostly replicates borderless window and allows easy window switching.

helmutbuhler · 2025-05-20T17:05:39Z

What is the benefit of no border?

....huh? Borderless windowed mode is a pretty standard feature in like 99% of modern games. It's entirely a personal preference/asthetic option, as a large number of folks hate seeing brightly colored title bars.

This does not change the default behavior, it just adds a command line option to enable the option.

Do you mean Windowed Fullscreen Mode? If this PR is trying to accomplish that, it needs quite a bit of work.
If not, I'm not aware of any game that allows you to hide the border in windowed mode, and Google Search didn't help there either. Can you mention some games that support this?

What is the benefit of no border?

I seriously hope you’re joking.

I don't understand this either.

ShizCalev · 2025-05-22T05:43:06Z

Do you mean Windowed Fullscreen Mode? If this PR is trying to accomplish that, it needs quite a bit of work.

That is not what I mean, no. Windowed borderless is not the same thing as windowed fullscreen mode, those are two different things.

If not, I'm not aware of any game that allows you to hide the border in windowed mode, and Google Search didn't help there either. Can you mention some games that support this?

Age of Chivalry, Alien Swarm, Aperture Tag, Apex Legends, Black Mesa, Blade Symphony, Bloody Good Time, Coastline to Atmosphere, Consortium, Contagion, Counter-Strike: Global Offensive, Counter-Strike: Malvinas, Counter-Strike: Online 2, Counter-Strike: Source, Dark Messiah of Might and Magic, Day of Defeat: Source, Day of Infamy, Deadlock, Dear Esther, Dino D-Day, Dota 2, Dystopia, E.Y.E.: Divine Cybermancy, Empires, Entropy: Zero, Entropy: Zero 2, Eternal Silence, Fistful of Frags, Flipside, Fortress Forever, G String, Garry's Mod, GoldenEye: Source, Half-Life 2, Half-Life 2: Capture the Flag, Half-Life 2: Deathmatch, Half-Life 2: Episode One, Half-Life 2: Episode Two, Half-Life 2: Lost Coast, Half-Life Deathmatch: Source, Half-Life: Source, Hunt Down the Freeman, Hybrid, Infra, Insurgency, Insurgency: Modern Infantry Combat, Iron Grip: The Oppression, JBMod, Jabroni Brawl, Jailbreak Source, Jurassic Life, Klaus Veen's Treason, Korsakovia, Left 4 Dead, Left 4 Dead 2, Mario Kart: Source, Minerva, Multiplayer mods, NeoTokyo, Nightmare House 2, No More Room in Hell, Nuclear Dawn, Operation Black Mesa, Perfect Dark: Source, Pirates, Vikings and Knights II, Portal, Portal 2, Portal Reloaded, Portal Stories: Mel, Portal: Prelude, Portal: Revolution, Postal III, Prospekt, Research and Development, Rexaura, Riot Act, SiN Episodes, SourceForts, Swelter, Synergy, Tactical Intervention, Team Fortress 2, Team Fortress 2 Classic, Terminal 7, The Beginner's Guide, The Hidden, The Ship, The Stanley Parable, Thinking with Time Machine, Titan: XCIX, Titanfall, Titanfall 2, Vampire: The Masquerade – Bloodlines, Vindictus, Zeno Clash, and Zombie Panic! Source -all- support this functionality with the exact same -noborder -windowed (or some variant thereof) launch parameter.

xezon · 2025-05-22T06:21:38Z

Generals/Code/Main/WinMain.cpp

@@ -75,6 +75,7 @@
 HINSTANCE ApplicationHInstance = NULL;  ///< our application instance
 HWND ApplicationHWnd = NULL;  ///< our application window handle
 Bool ApplicationIsWindowed = false;
+Bool ApplicationIsBorderless = false; // TheSuperHackers @feature @ShizCalev 04/04/2025 - Borderless Windowed support


xezon · 2025-05-22T06:22:50Z

Generals/Code/Main/WinMain.cpp

@@ -674,7 +675,8 @@ static Bool initializeAppWindows( HINSTANCE hInstance, Int nCmdShow, Bool runWin
   // Create our main window
 	windowStyle =  WS_POPUP|WS_VISIBLE;
 	if (runWindowed) 
-		windowStyle |= WS_DLGFRAME | WS_CAPTION | WS_SYSMENU;
+		if(!ApplicationIsBorderless)
+			windowStyle |= WS_DLGFRAME | WS_CAPTION | WS_SYSMENU;


No WS_SYSMENU when ApplicationIsBorderless ? Fullscreen has WS_SYSMENU.

Stale review

helmutbuhler

... Source -all- support this functionality with the exact same -noborder -windowed (or some variant thereof) launch parameter.

So, what is this Multiplayer mods game that you listed there? ;)

You could have just said that the Source-Engine has this option and a bunch of games inherit that option from there. So I'm still not convinced this option is that useful, but if you are this invested in it I guess we can take it in.

helmutbuhler · 2025-05-22T17:17:39Z

GeneralsMD/Code/Main/WinMain.cpp

@@ -926,6 +928,8 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 			//added a preparse step for this flag because it affects window creation style
 			if (stricmp(token,"-win")==0)
 				ApplicationIsWindowed=true;
+			if(stricmp(token,"-noborder")==0)


Can we add this in CommandLine.cpp as well, just as a dummy or comment? Reason being that if someone wants to know which options are available, that is the place to look.

Just a side note: I think it would be neat to implement a logging that prints out all possible arguments when launching it on the command line. In some future change.

xezon · 2025-05-30T08:46:20Z

Generals/Code/Main/WinMain.cpp

@@ -901,6 +903,8 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 			//added a preparse step for this flag because it affects window creation style
 			if (stricmp(token,"-win")==0)
 				ApplicationIsWindowed=true;
+			if(stricmp(token,"-noborder")==0)


xezon · 2025-05-30T08:47:56Z

GeneralsMD/Code/Main/WinMain.cpp

@@ -926,6 +928,8 @@ Int APIENTRY WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance,
 			//added a preparse step for this flag because it affects window creation style
 			if (stricmp(token,"-win")==0)
 				ApplicationIsWindowed=true;
+			if(stricmp(token,"-noborder")==0)


Just a side note: I think it would be neat to implement a logging that prints out all possible arguments when launching it on the command line. In some future change.

DevGeniusCode added Enhancement Minor labels Mar 3, 2025

Adds a "-noborder" launch argument for borderless windowed mode

195b2b5

ShizCalev force-pushed the windowless-border branch 2 times, most recently from 773404a to a0d9145 Compare March 4, 2025 10:27

Comments

42e597b

ShizCalev force-pushed the windowless-border branch from a0d9145 to 42e597b Compare March 4, 2025 10:28

ShizCalev changed the title ~~Adds a "-noborder" launch argument for borderless windowed mode~~ Feature: Adds a "-noborder" launch argument for borderless windowed mode Mar 4, 2025

DevGeniusCode added Gen ZH labels Mar 4, 2025

Generalcamo previously requested changes Mar 8, 2025

View reviewed changes

GeneralsMD/Code/Main/WinMain.cpp Outdated Show resolved Hide resolved

Apply suggestions from code review

865e14c

Co-authored-by: Cody Brittain <1779662+Generalcamo@users.noreply.github.com>

xezon changed the title ~~Feature: Adds a "-noborder" launch argument for borderless windowed mode~~ Add "-noborder" launch argument for borderless windowed mode Mar 30, 2025

ShizCalev commented May 19, 2025

View reviewed changes

Apply suggestions from code review

36b7cf8

xezon reviewed May 22, 2025

View reviewed changes

helmutbuhler reviewed May 22, 2025

View reviewed changes

xezon reviewed May 30, 2025

View reviewed changes

Add "-noborder" launch argument for borderless windowed mode #327

Are you sure you want to change the base?

Add "-noborder" launch argument for borderless windowed mode #327

Uh oh!

Conversation

ShizCalev commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

helmutbuhler commented May 19, 2025

Uh oh!

ShizCalev commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xezon commented May 20, 2025

Uh oh!

ShizCalev commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trax1990 commented May 20, 2025

Uh oh!

Mauller commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

helmutbuhler commented May 20, 2025

Uh oh!

ShizCalev commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xezon May 22, 2025

Choose a reason for hiding this comment

Uh oh!

xezon May 22, 2025

Choose a reason for hiding this comment

Uh oh!

helmutbuhler left a comment

Choose a reason for hiding this comment

Uh oh!

helmutbuhler May 22, 2025

Choose a reason for hiding this comment

Uh oh!

xezon May 30, 2025

Choose a reason for hiding this comment

Uh oh!

xezon May 30, 2025

Choose a reason for hiding this comment

Uh oh!

xezon May 30, 2025

Choose a reason for hiding this comment

Uh oh!

ShizCalev commented Mar 3, 2025 •

edited

Loading

ShizCalev commented May 19, 2025 •

edited

Loading

ShizCalev commented May 20, 2025 •

edited

Loading

Mauller commented May 20, 2025 •

edited

Loading

ShizCalev commented May 22, 2025 •

edited

Loading