[GEN] Backport left click deselect functionality with Alternate Mouse Setup from Zero Hour

[ShizCalev]

• Resolves [BUG] Inconsistent "Alternative mouse setup" between CCG and ZH #305
• Relates to Merge Generals and Zero Hour code into one #555
• Requires issue [GEN] Create CRC for original generals exe and inject it in the code #525 to be resolved first

This change backports the left mouse click deselect functionality with the Alternate Mouse Setup from Zero Hour to Generals. Previously in Generals it was not possible to deselect units or buildings with a mouse click when the Alternate Mouse Setup was enabled.

[Skyaero42]

Backported correctly from ZH, but the Superhacker comments need to disappear to make it GEN and ZH version identical for future merging.

Compiled and tested it and the option does indeed appear in the options menu.

[xezon]

Can someone please explain what this changes? I do not understand the title and I also do not understand "PreventLeftClickDeselectionInAlternateMouseModeForOneClick".

[Skyaero42]

Can someone please explain what this changes? I do not understand the title and I also do not understand "PreventLeftClickDeselectionInAlternateMouseModeForOneClick".

"Alternate mouse mode" is a setting in the options menu in the game moves the action commands (move, attack etc) from the left to the right mouse button. The left mouse button would then be used to deselect any selected unit(s).

However in Generals this is bugged and pressing the left button doesn't deselect. In ZH the developers fixed this.
What the code checks for - I think - if it is really a deselect command. And not e.g. a left click to place a building, because you don't want to deselect the dozer at that point.

This is a direct code-copy from ZH, so also helps with unifying code.

[xezon]

Ok now I understand. I updated the title and description to clarify what this does.

The change looks safe, but perhaps it would still be worthwhile to test if this would cause multiplayer mismatch. I don't think it will but I am not 100% sure.

[Skyaero42]

That's fine. Will need to fix the ExeCRC issue first. I've linked it in the start post as a reminder

[Skyaero42]

Tested, no mismatch