Skip to content

Fix Nationalism and Patriotism bonuses being applied regardless of horde status #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Nationalism and Patriotism bonuses being applied regardless of horde status #385

wants to merge 2 commits into from
+37 −29

Conversation

Generalcamo
Copy link

Fixes #173

@Generalcamo Generalcamo added Bug Something is not working right China Affects China faction Major Severity: Minor < Major < Critical < Blocker Generals Related Generals only ZeroHour Relates to Zero Hour labels Mar 6, 2025
@xezon xezon added the GameMismatchWith104 Affects game state towards original 1.04 label Mar 6, 2025
@Generalcamo Generalcamo requested a review from xezon March 6, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorcerer86pt sorcerer86pt sorcerer86pt approved these changes

@xezon xezon Awaiting requested review from xezon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Bug Something is not working right China Affects China faction GameMismatchWith104 Affects game state towards original 1.04 Generals Related Generals only Major Severity: Minor < Major < Critical < Blocker ZeroHour Relates to Zero Hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

China Nationalism (and Patriotism) apply fire rate bonus to units regardless of Horde bonus
3 participants
@Generalcamo @xezon @sorcerer86pt