Changes necessary for a 64bit build on a modern compiler (VS2019) #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio & Video (ie bink) are disabled Swap out DX8 for DX9 since DX8 is 32bit only 'Fix' the hashing for AsciiString Add DEBUG_WARNING to replace DEBUG_CRASH for non-fatal errors
tintinhamans
added
Critical
|
This is a massive change doing all sorts of different things. We cannot merge this or other changes of this kind, but we can use it as a reference when so needed. |
Generalcamo
reviewed
Mar 12, 2025
Comment on lines
+1
to
+11
| NVASM | ||
| https://web.archive.org/web/20061006093538/http://developer.nvidia.com/object/nvasm.html | ||
|
|
||
| GameSpy | ||
| https://github.com/GameProgressive/UniSpySDK | ||
|
|
||
| LZHL (under libs/_lzhl | ||
| https://github.com/mistydemeo/quickbms/tree/5752a6a2a38e16211952553fcffa59570855ac42 | ||
|
|
||
| DirectX 8 | ||
| https://github.com/edgeforce/directx8 |
There was a problem hiding this comment.
With the possible exception of LZHL (which has vague licensing), these are incompatible with the GPLv3 license. That alone renders this PR unable to be merged, even if this was reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should compile with modern VS. Working with VS2019
Audio & Video (ie bink) are disabled
Swap out DX8 for DX9 since DX8 is 32bit only
'Fix' the hashing for AsciiString
Add DEBUG_WARNING to replace DEBUG_CRASH for non-fatal errors