Skip to content

[GEN] Fix incorrect AsciiString hash implementation for non-stlport #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mauller
Copy link

@Mauller Mauller commented Mar 25, 2025

Copy the fixes that were made in the zero hour code by Xezon.

This fixes as fatal error at startup that prevents the game from starting.

Copy the fixes that were made in the zero hour code by Xezon.
@DevGeniusCode DevGeniusCode added Build Anything related to building, compiling Gen Relates to Generals Major Severity: Minor < Major < Critical < Blocker labels Mar 25, 2025
Copy link

@stevebone stevebone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed.

@OmniBlade OmniBlade merged commit 9f8620a into TheSuperHackers:main Mar 25, 2025
6 checks passed
@xezon xezon changed the title [Gen] Fix incorrect AsciiString hash implementation for non-stlport [GEN] Fix incorrect AsciiString hash implementation for non-stlport Mar 25, 2025
tintinhamans pushed a commit to tintinhamans/GeneralsGameCode that referenced this pull request Mar 26, 2025
…erHackers#507)

Copy the fixes that were made in the zero hour code by Xezon.
tintinhamans pushed a commit to tintinhamans/GeneralsGameCode that referenced this pull request Mar 26, 2025
…erHackers#507)

Copy the fixes that were made in the zero hour code by Xezon.
bobtista pushed a commit to bobtista/GeneralsGameCode that referenced this pull request Mar 27, 2025
…erHackers#507)

Copy the fixes that were made in the zero hour code by Xezon.
@Mauller Mauller deleted the fix-asciistring-hash-generals branch March 29, 2025 10:41
@xezon xezon added this to the Code foundation build up milestone Mar 31, 2025
@xezon xezon added the Stability Concerns stability of the runtime label Apr 28, 2025
ViTeXFTW added a commit to ViTeXFTW/GeneralsGameCode that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Anything related to building, compiling Gen Relates to Generals Major Severity: Minor < Major < Critical < Blocker Stability Concerns stability of the runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants