Fix intrin_compat.h to work for MinGW #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
reviewed
Apr 13, 2025
| @@ -132,17 +133,20 @@ static inline uint64_t _rdtsc() | |||
| #endif | |||
|
|
|||
| #ifndef cpuid | |||
| #if defined(_MSC_VER) | |||
| #if (defined _M_IX86 || defined _M_X64 || defined __i386__ || defined __amd64__) | |||
There was a problem hiding this comment.
Goal was to use dummy implementation on architectures other than x86 and x86_64. (As cpuid is instruction specific to x86) Condition was previously only used only for GCC and clang, but same applies to MSVC.
zzambers
force-pushed
the
intrin-compat-fixes
branch
from
36370c0 to
32a5d0f
Compare
zzambers
force-pushed
the
intrin-compat-fixes
branch
from
32a5d0f to
4b3448e
Compare
|
just fixed comment |
xezon
added
Minor
xezon
changed the title
xezon
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes of problems in intrin_compat (with MinGW):
_rdtscafter inclusion of<intrin.h>, before defining it as inline func. (GCC/Mingw header already defines_rdtscas alias for__rdtsc)intrin.hshould be consistent and depend_WIN32everywhere (rather than on_MSC_VERin some places) to avoid problems on MinGWThis was extracted from bigger change-set fixing build on MinGW: #547