Skip to content

[GEN][ZH] Fix COM related compile errors for MinGW #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

[GEN][ZH] Fix COM related compile errors for MinGW #672

merged 1 commit into from
Apr 13, 2025

Conversation

zzambers
Copy link

COM related fixes to be able to build using MinGW.

  • fixes to idl files to be able to build using widl
  • fixes to c++ to be able to build using mingw toolchain + atl library from reactos sdk (MinGW itself does not include atl)

This was extracted from bigger change-set fixing build on MinGW: #547

@zzambers zzambers mentioned this pull request Apr 13, 2025
Open
xezon
xezon approved these changes Apr 13, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@zzambers
Copy link
Author

zzambers commented Apr 13, 2025 •
edited
Loading

just fixed typo

@xezon xezon added this to the Code foundation build up milestone Apr 13, 2025
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Build Anything related to building, compiling labels Apr 13, 2025
@xezon xezon changed the title [GEN][ZH] COM related fixes for MinGW [GEN][ZH] Fix COM related compile errors for MinGW Apr 13, 2025
@xezon xezon merged commit 278b40a into TheSuperHackers:main Apr 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Build Anything related to building, compiling Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
Code foundation build up
Development

Successfully merging this pull request may close these issues.
2 participants
@zzambers @xezon