OpenAL support #784
Draft
OpenAL support #784
+4,205
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliwir
force-pushed
the
openal-support
branch
3 times, most recently
from
b2c6d57 to
8d58e1d
Compare
Mauller
reviewed
May 6, 2025
Comment on lines
28
to
51
| // union | ||
| // { | ||
| HSAMPLE m_sample; | ||
| H3DSAMPLE m_3DSample; | ||
| HSTREAM m_stream; | ||
| // }; | ||
|
|
||
| PlayingAudioType m_type; | ||
| volatile PlayingStatus m_status; // This member is adjusted by another running thread. | ||
| AudioEventRTS *m_audioEventRTS; | ||
| void *m_file; // The file that was opened to play this | ||
| Bool m_requestStop; | ||
| Bool m_cleanupAudioEventRTS; | ||
| Int m_framesFaded; | ||
|
|
||
| PlayingAudio() : | ||
| m_type(PAT_INVALID), | ||
| m_audioEventRTS(NULL), | ||
| m_requestStop(false), | ||
| m_cleanupAudioEventRTS(true), | ||
| m_sample(0), | ||
| m_3DSample(0), | ||
| m_stream(0), | ||
| m_framesFaded(0) | ||
| { } | ||
| }; |
There was a problem hiding this comment.
Yeah this all changed when i merged generals and zero hour, i reverted the changes zero hour brought in and went with the original generals way of doing it by using the union again. I then initialise m_sample(NULL) and dropped m_3DSample and m_stream from the initialiser list. They are all just pointers.
There was a problem hiding this comment.
Alright, will adapt this. Thanks for the heads up
feliwir
force-pushed
the
openal-support
branch
2 times, most recently
from
c3b0cbf to
feeb1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.