Skip to content

[GEN][ZH] Fix possible division by zero in W3DCommandBarGenExpDraw() #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

[GEN][ZH] Fix possible division by zero in W3DCommandBarGenExpDraw() #810

merged 1 commit into from
May 5, 2025

Conversation

Mauller
Copy link

@Mauller Mauller commented May 4, 2025 •
edited by xezon
Loading

This PR prevents a possible division by zero from occuring when player progress is calculated.

@Mauller Mauller self-assigned this May 4, 2025
@Mauller Mauller added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Fix Is fixing something and removed Bug Something is not working right labels May 4, 2025
roossienb
roossienb approved these changes May 5, 2025
View reviewed changes
Copy link

@roossienb roossienb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon xezon added Crash This is a crash Mod Relates to Mods or modding and removed Gen Relates to Generals ZH Relates to Zero Hour labels May 5, 2025
@Mauller Mauller force-pushed the fix-zero-division-in-w3dcontrolbar branch from b643498 to 15ff8ef Compare May 5, 2025 14:17
@Mauller
Copy link
Author

Mauller commented May 5, 2025

Tweaked and pushed.

@Mauller Mauller force-pushed the fix-zero-division-in-w3dcontrolbar branch from 15ff8ef to e7f45ff Compare May 5, 2025 17:14
@xezon xezon added this to the Stability fixes milestone May 5, 2025
@xezon xezon merged commit afd9c30 into TheSuperHackers:main May 5, 2025
19 checks passed
@xezon xezon deleted the fix-zero-division-in-w3dcontrolbar branch May 5, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

@roossienb roossienb roossienb approved these changes

Assignees

@Mauller Mauller

Labels
Crash This is a crash Fix Is fixing something Minor Severity: Minor < Major < Critical < Blocker Mod Relates to Mods or modding
Projects
None yet
Milestone
Stability fixes
Development

Successfully merging this pull request may close these issues.

Division by zero crash in W3DCommandBarGenExpDraw() when experience points for level up are 0
3 participants
@Mauller @xezon @roossienb