[GEN] Fix wrong water color on radar

[roossienb]

• Follow up for [GEN] Backport WaterTransparencySetting additions from Zero Hour #777
• Fixes [GEN] Radar does not render water #822

[Mauller]

Did you see how this is handled in zero hour?

It's likely that zero hour implicitly sets these between 0 and 1 in config somewhere else.

[roossienb]

The radar water color has a default value defined in water.h in integer-notation (0-255)
When the application starts, it first assigns this default value.
Then it tries to load any overrides from ini's. However in the INI parser the integers (0-255) is parsed into a float value (0-1)

RadarWaterColor is defined in ZH's ini file, but not in Generals. Generals didn't use an INI reader for radar water calor before the backport introduced in #777 So Generals returns to the default value (in integer notation), while ZH returns the INI value that is converted to float-notation by the INI parser.

The original bug was in ZH (default values being integer, rather then float), but wasn't discovered, because INI overwrote them. With no INI in generals, the bug appeared.

The fix should be to convert the default value from integer to float notation for both games, although ZH uses the INI. Will adjust accordingly

[OmniBlade]

The radar water color has a default value defined in water.h in integer-notation (0-255) When the application starts, it first assigns this default value. Then it tries to load any overrides from ini's. However in the INI parser the integers (0-255) is parsed into a float value (0-1)

RadarWaterColor is defined in ZH's ini file, but not in Generals. So Generals returns to the default value (in integer notation), while ZH returns the INI value that is converted to float-notation by the INI parser.

RadarWaterColor is a value that can be overridden by maps as well. So not all maps in GEN may bug out - which may explain why we didn't pick up on it initially.

The fix should be to convert the default value from integer to float notation for both games, although ZH uses the INI. Will adjust accordingly

Does Generals have a parser for the ini and just not have it defined? Might want to also back port the parser if not to align things more with the ZH code?

[roossienb]

Does Generals have a parser for the ini and just not have it defined? Might want to also back port the parser if not to align things more with the ZH code?

RGB parser is present, its just the INI configuration that is the issue