[GEN][ZH] Demote throw to assert in AsciiString::format_va, UnicodeString::format_va #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
helmutbuhler
requested changes
May 9, 2025
| throw ERROR_OUT_OF_MEMORY; | ||
| set(buf); | ||
| validate(); | ||
| const int result = _vsnprintf(buf, sizeof(buf)/sizeof(WideChar)-1, format, args); |
| const int result = _vsnprintf(buf, sizeof(buf)/sizeof(WideChar)-1, format, args); | ||
| if (result >= 0) | ||
| { | ||
| set(buf); |
There was a problem hiding this comment.
can we set buf[MAX_FORMAT_BUF_LEN-1] = 0; while we are at it?
There was a problem hiding this comment.
Regarding _vsnprintf & _snprintf, I planned to do another change.
This was referenced May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change demotes the unnecessary throw to debug assert in AsciiString::format_va and UnicodeString::format_va. Unnecessary throw because this format error is not necessarily a fatal error that needs to terminate the process. The program may just run fine with this error. The debug assert is enough to see the error.
Original
This change